r1990 crashes after trying to start nonexistent Tor executable

[edmanm]

From arma:

"I configured my Vidalia settings to point to a Tor executable that doesn't exist, and then asked it to start Tor, and then clicked 'cancel' when it complained. Poof."

This crash occurs on all platforms.

The backtrace on arma's Debian etch is as follows:

#0  0xb76a3ed3 in QProcessManager::remove (this=0x8308bd8, process=0x8fcc6f8)
    at io/qprocess_unix.cpp:338
#1  0xb76a44b0 in QProcessPrivate::waitForDeadChild (this=0x9cc0660)
    at io/qprocess_unix.cpp:1123
#2  0xb76695d9 in QProcessPrivate::_q_startupNotification (this=0x9cc0660)
    at io/qprocess.cpp:673
#3  0xb766e961 in QProcess::qt_metacall (this=0x83d95d8, 
    _c=QMetaObject::InvokeMetaMethod, _id=12, _a=0xbfd07dbc)
    at .moc/release-shared/moc_qprocess.cpp:101
#4  0x08102b6f in TorProcess::qt_metacall ()
#5  0xb76d0565 in QMetaObject::activate (sender=0x92e5210, 
    from_signal_index=4, to_signal_index=4, argv=<value optimized out>)
    at kernel/qobject.cpp:2911
#6  0xb76d0ecc in QMetaObject::activate (sender=0x92e5210, m=0xb775d1b0, 
    local_signal_index=0, argv=0xbfd07dbc) at kernel/qobject.cpp:2954
#7  0xb76eff21 in QSocketNotifier::activated (this=0x92e5210, _t1=11)
    at .moc/release-shared/moc_qsocketnotifier.cpp:79
#8  0xb76d780f in QSocketNotifier::event (this=0x92e5210, e=0xbfd08170)
    at kernel/qsocketnotifier.cpp:276
#9  0xb78ac59f in QApplicationPrivate::notify_helper (this=0x83058a8, 
    receiver=0x92e5210, e=0xbfd08170) at kernel/qapplication.cpp:3435
#10 0xb78aed82 in QApplication::notify (this=0xbfd084c8, receiver=0x92e5210, 
    e=0xbfd08170) at kernel/qapplication.cpp:3010
#11 0xb76e24cd in socketNotifierSourceDispatch (source=0x8307478)
    at kernel/qcoreapplication.h:183
#12 0xb70c3731 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
#13 0xb70c67a6 in g_main_context_check () from /usr/lib/libglib-2.0.so.0
#14 0xb70c6d27 in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0
#15 0xb76e26a8 in QEventDispatcherGlib::processEvents (this=0x83061e8, 
    flags=@0xbfd082b8) at kernel/qeventdispatcher_glib.cpp:363
#16 0xb7929fe5 in QGuiEventDispatcherGlib::processEvents (this=0x83061e8, 
    flags=@0xbfd082e4) at kernel/qguieventdispatcher_glib.cpp:178
#17 0xb76be291 in QEventLoop::processEvents (this=0xbfd08350, 
    flags=@0xbfd08318) at kernel/qeventloop.cpp:125
#18 0xb76be39a in QEventLoop::exec (this=0xbfd08350, flags=@0xbfd08358)
    at kernel/qeventloop.cpp:171
#19 0xb76c0756 in QCoreApplication::exec () at kernel/qcoreapplication.cpp:720
#20 0xb78ac017 in QApplication::exec () at kernel/qapplication.cpp:2928
#21 0x080bc29d in main ()

[edmanm]

Fixed in r1993. It would be nice if someone still running Qt 4.1 could test that patch, though.